You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josh-fell (via GitHub)" <gi...@apache.org> on 2023/02/15 04:59:52 UTC
[GitHub] [airflow] josh-fell opened a new pull request, #29549: Fix and augment `check-for-inclusive-language` CI check
josh-fell opened a new pull request, #29549:
URL: https://github.com/apache/airflow/pull/29549
Related: #15994 #23090
The current CI check for preventing non-inclusive language failed to catch several uses of "dummy" in docs. Upon inspection, the `(?x)` inline modifier was missing from the regex (although intended in #23090). Adding this modifier revealed these "dummy" instances and others related non-inclusive occurrences. Additionally, the exclusion list seemed to broad to being committed to the project's use of inclusive language. There are still places in which directories as excluded as a whole, but the list now is more tailored to non-inclusive occurrences that are beyond the purview of Airflow, history, dev/test files, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on PR #29549:
URL: https://github.com/apache/airflow/pull/29549#issuecomment-1439398230
Force pushing to hopefully get passed the test_cli_internal_api_background test now that it's quarantined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell merged pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell merged PR #29549:
URL: https://github.com/apache/airflow/pull/29549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #29549:
URL: https://github.com/apache/airflow/pull/29549#discussion_r1113079693
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -240,7 +240,7 @@ def get_pandas_df(
query. The DbApiHook method must be overridden because Pandas
doesn't support PEP 249 connections, except for SQLite. See:
- https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L447
+ https://github.com/pydata/pandas/blob/main/pandas/io/sql.py#L447
Review Comment:
Good point! I updated the links (they were outdated anyway). I think keeping the links there is still helpful. There is a pandas issue also linked, but reading through that conversation can be cumbersome even though it is good context for _why_ only SQLite is supported with DBAPIv2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29549:
URL: https://github.com/apache/airflow/pull/29549#discussion_r1111114409
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -240,7 +240,7 @@ def get_pandas_df(
query. The DbApiHook method must be overridden because Pandas
doesn't support PEP 249 connections, except for SQLite. See:
- https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L447
+ https://github.com/pydata/pandas/blob/main/pandas/io/sql.py#L447
Review Comment:
```suggestion
```
I think it could be removed, if we attach link to the branch without specific commit then reference to line(s) could be changes thought the time:
Right not it refers to
```console
Whether to use nullable dtypes as default when reading data. If
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #29549:
URL: https://github.com/apache/airflow/pull/29549#discussion_r1113079693
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -240,7 +240,7 @@ def get_pandas_df(
query. The DbApiHook method must be overridden because Pandas
doesn't support PEP 249 connections, except for SQLite. See:
- https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L447
+ https://github.com/pydata/pandas/blob/main/pandas/io/sql.py#L447
Review Comment:
Good point! I updated the links in da85a59f3ba420c4c4ec1abe9fc393840516bb2a (they were outdated anyway). I think keeping the links there is still helpful. There is a pandas issue also linked, but reading through that conversation can be cumbersome even though it is good context for _why_ only SQLite is supported with DBAPIv2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #29549: Fix and augment `check-for-inclusive-language` CI check
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #29549:
URL: https://github.com/apache/airflow/pull/29549#issuecomment-1481609895
Requires a bunch of CI/dev commits to avoid conflicts on `.pre-commit-config.yaml` moving to 2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org