[jira] [Comment Edited] (HBASE-22038) fix building failures

["Junhong Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792373#comment-16792373 ] 

Junhong Xu edited comment on HBASE-22038 at 3/14/19 11:06 AM:
--------------------------------------------------------------

{quote}Dockerfile changes look good to me. What's up with removing all of the proto files? Is the expectation that we pull them directly from hbase-protocol-shaded instead?{quote}
Yeah. As you see, the proto files will be copied from hbase-protocol instead of the right hbase-protocol-shaded for now, but it cann't be compiled successfully even the urls are corrected. The error is that the protobuf files are inconsistent and duplicate for some messages.Discussed with [~zghaobac], it seems that the hbase-protocol-shaded is latest, so I changed the copy source dir from hbase-protocol to hbase-protocol-shaded. If so, it  always keeps consistent between the client side and the server side, as the Java client.
  As you suggest, I agree that the native client is moved  to another repo. In this situation, we should also keep them consistent in another way. That's another story. 


was (Author: joseph295):
{quote}Dockerfile changes look good to me. What's up with removing all of the proto files? Is the expectation that we pull them directly from hbase-protocol-shaded instead?{quote}
Yeah. As you see, the proto files will be copied from hbase-protocol instead of the right hbase-protocol-shaded for now, but it cann't be compiled successfully even the urls are corrected. The error is that the protobuf files are not inconsistent and duplicate for some messages.Discussed with [~zghaobac], it seems that the hbase-protocol-shaded is latest, so I changed the copy source dir from hbase-protocol to hbase-protocol-shaded. If so, it  always keeps consistent between the client side and the server side, as the Java client.
  As you suggest, I agree that the native client is moved  to another repo. In this situation, we should also keep them consistent in another way. That's another story. 

> fix building failures
> ---------------------
>
>                 Key: HBASE-22038
>                 URL: https://issues.apache.org/jira/browse/HBASE-22038
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Junhong Xu
>            Assignee: Junhong Xu
>            Priority: Minor
>             Fix For: HBASE-14850
>
>         Attachments: HBASE-22038.HBASE-14850.v01.patch, HBASE-22038.HBASE-14850.v02.patch
>
>
> When building the hbase c++ client with Dockerfile, it fails, because of the url resources not found. But this patch just solve  the problem in temporary, cos when some dependent libraries are removed someday, the failure will appear again. Maybe a base docker image which contains all these dependencies maintained by us is required in the long run. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)