[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3933: [KYUUBI #3887] Provide kyuubiServerPrincipal as alias for principal i…

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3933:
URL: https://github.com/apache/incubator-kyuubi/pull/3933#discussion_r1042912970


##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java:
##########
@@ -468,7 +468,9 @@ public boolean connect(Properties props) throws IOException {
     }
 
     beeLine.info("Connecting to " + url);
-    if (Utils.parsePropertyFromUrl(url, JdbcConnectionParams.AUTH_PRINCIPAL) == null) {
+    if (Utils.parsePropertyFromUrl(url, JdbcConnectionParams.AUTH_PRINCIPAL) == null
+        || Utils.parsePropertyFromUrl(url, JdbcConnectionParams.AUTH_KYUUBI_SERVER_PRINCIPAL)

Review Comment:
   static import JdbcConnectionParams.* so we can short the code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org