You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/24 15:33:18 UTC

[GitHub] [cloudstack] rvalle opened a new pull request #5366: updated maven dependency due to #5363

rvalle opened a new pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366


   Updates maven missing dependency 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rvalle commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-904759901


   @DaanHoogland perhaps you can review this PR, I think you wrote this tests.
   The maven-ldap artifact is missing. 
   I have looked at the other ldap plugin from the same author, the ldap-unit-test, and that seems to be OK, it is the last version in 1.x, there are newer versions 2.x, but they were released 4 years later.
   This update impacts the unit tests: ldap/LdapUnitConnectionTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rvalle commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907143776


   @DaanHoogland the same missing artifact is in 4.15 and 4.14 too.
   
   However be aware that this affects only the building process, does not affect to packages already shipped. So, this should be fixed in all codebases that are "alive" and for which you expect to release additional maintenance releases.
   
   Otherwise you could potentially get your build to fail because of the missing artifact (unless it is cached somewhere, like a nexus repo or local .mvn).  
   
   it might be a good idea to turn off maven caching for final releases, so that you can assure that all artifacts are still alive. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907043142


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1033


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907192689


   ok thanks @rvalle , can you re-target this PR for 4.15 than?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020653


   looks ok @rvalle 
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020947


   @rvalle did you test/encounter this in 4.15 as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020795


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rvalle commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907593647


   @DaanHoogland is that ok now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rvalle commented on pull request #5366: updated maven dependency due to #5363

Posted by GitBox <gi...@apache.org>.
rvalle commented on pull request #5366:
URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-905205712


   @DaanHoogland I cannot identify LdapUnitConnectionTest in the Travis logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org