You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/05 09:49:59 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
eolivelli opened a new pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484
Motivation:
Currently with the Debezium and with the Kafka Connect Adapter you cannot configure authentication in order to connect to a Pulsar cluster that requires "Token" authentication
Changes:
With this patch we are adding support in the Debezium and in the Kafka Connect Adaptor for connecting to a Pulsar instance that supports Token authentication.
Documentation:
Documentation will be provided as a follow up patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-833262428
@sijie @rdhabalia @freeznet
I agree with the comments in #8668 and we probably should provide PulsarClient together with PulsarAdmin.
This patch was a quick and dirty fix that we had in some local fork in order to unblock usage of these connectors in environments where you use Token Auth.
I wanted to shared this patch more to start a discussion and to see the feedback from the community.
if we want to go down the way of providing PulsarClient I am to work on that solution.
IIRC there were some discussions about Classpath pollution introduced by adding support for PulsarAdmin,
personally I believe that it is better to add PulsarClient and PulsarAdmin to the Context, so I am happy to go that way. It will make life easier for implementors of Pulsar IO adapters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-835116251
I am closing this PR, I switched it to draft only to keep it visible.
Sorry I wasn't clear.
I agree that this would be only a partial solution, I meant this PR only to be another starting point for the discussion about needing a full PulsarClient here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-834498706
I have started a discussion on dev@ about having a way to have the PulsarClient object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli edited a comment on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-833262428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-834890494
> This patch was a quick and dirty fix that we had in some local fork in order to unblock usage of these connectors in environments where you use Token Auth.
Let's avoid adding any **dirty** hack in the open-source project. If your team wants to maintain your own hack, please maintain that in your own branch.
> IIRC there were some discussions about Classpath pollution introduced by adding support for PulsarAdmin,
It is a problem for Pulsar Admin. But it is not a problem for PulsarClient, because we already expose Producer and Message in the context object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org