You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sandip-db (via GitHub)" <gi...@apache.org> on 2023/11/07 08:27:12 UTC
[PR] [SPARK-44751][SQL] XML: Refactor TypeCast and timestampFormatter [spark]
sandip-db opened a new pull request, #43697:
URL: https://github.com/apache/spark/pull/43697
### What changes were proposed in this pull request?
- Move initialization of TimestampFormatter from XmlOptions to StaxXmlParser, StaxXmlGenerator and XmlInferSchema.
- Move functions from typecast.scala to StaxXmlParser or XmlInferSchema
- Convert XmlInferSchema to a class
### Why are the changes needed?
Some of the timestampformatter fields were not correctly initialized when accessed in StaxXmlParser in the executor. This was resulting in some timestamp parsing failures. Moving the initialization of timestampformatter to StaxXmlParser fixed the issue.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added new unit tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44751][SQL] XML: Refactor TypeCast and timestampFormatter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43697: [SPARK-44751][SQL] XML: Refactor TypeCast and timestampFormatter
URL: https://github.com/apache/spark/pull/43697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44751][SQL] XML: Refactor TypeCast and timestampFormatter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43697:
URL: https://github.com/apache/spark/pull/43697#issuecomment-1799300137
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44751][SQL][FOLLOW-UP] XML: Refactor TypeCast and timestampFormatter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43697:
URL: https://github.com/apache/spark/pull/43697#issuecomment-1799301895
Let's file a new jira next time. The change is too big to be a followup :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org