You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (Created) (JIRA)" <ji...@apache.org> on 2011/12/26 18:20:30 UTC
[jira] [Created] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separately Broker process
QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process
---------------------------------------------------------------------------------------------------------------
Key: QPID-3712
URL: https://issues.apache.org/jira/browse/QPID-3712
Project: Qpid
Issue Type: Bug
Components: Java Tests
Affects Versions: 0.15
Reporter: Keith Wall
Assignee: Keith Wall
Priority: Minor
QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separately Broker process
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3712:
-----------------------------
Fix Version/s: 0.15
> QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3712
> URL: https://issues.apache.org/jira/browse/QPID-3712
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
> This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separate Broker process
Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3712.
----------------------------------
Resolution: Fixed
Changes look good.
I have raised QPID-3728 to cover the fact that many of the uses of this method are no longer necessary.
> QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separate Broker process
> -------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3712
> URL: https://issues.apache.org/jira/browse/QPID-3712
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
> This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separate Broker process
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3712:
-----------------------------
Summary: QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separate Broker process (was: QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process)
> QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separate Broker process
> -------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3712
> URL: https://issues.apache.org/jira/browse/QPID-3712
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
> This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separately Broker process
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3712:
-----------------------------
Status: Ready To Review (was: In Progress)
> QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3712
> URL: https://issues.apache.org/jira/browse/QPID-3712
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
>
> QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
> This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3712) QpidBrokerTestCase#isExternalBroker
uses incorrect logic to determine if testing with separately Broker process
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3712:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
Hi Robbie, can you review this change please?
> QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3712
> URL: https://issues.apache.org/jira/browse/QPID-3712
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
>
> QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.
> This problem contributed to QPID-3566.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org