You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/31 19:53:47 UTC

[GitHub] [spark] EnricoMi opened a new pull request, #37351: [SPARK-38864][SQL][Followup] Make AnalysisException message deterministic

EnricoMi opened a new pull request, #37351:
URL: https://github.com/apache/spark/pull/37351

   ### What changes were proposed in this pull request?
   Turns out the AnalysisException message is sensitive to the way Scala maps data types as used to generate the error message. This fix makes the error message deterministic.
   
   https://github.com/apache/spark/pull/36150#discussion_r933962854
   
   ### Why are the changes needed?
   This fixes tests.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Test should not fail for Scala 2.13 anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37351: [SPARK-38864][SQL][Followup] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37351:
URL: https://github.com/apache/spark/pull/37351#discussion_r934061373


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -101,8 +101,9 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
   def unpivotValDataTypeMismatchError(values: Seq[NamedExpression]): Throwable = {

Review Comment:
   uhoh, seems like it fails in Scala 2.12 now 😢 https://github.com/G-Research/spark/runs/7601695538?check_suite_focus=true
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37351:
URL: https://github.com/apache/spark/pull/37351#issuecomment-1201970303

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37351:
URL: https://github.com/apache/spark/pull/37351#issuecomment-1201940599

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] EnricoMi commented on pull request #37351: [SPARK-38864][SQL][Followup] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #37351:
URL: https://github.com/apache/spark/pull/37351#issuecomment-1200489675

   @HyukjinKwon this should fix the test failure in Scala 2.13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] EnricoMi commented on pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #37351:
URL: https://github.com/apache/spark/pull/37351#issuecomment-1200828323

   Tests pass locally with Scala 2.13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] EnricoMi commented on pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #37351:
URL: https://github.com/apache/spark/pull/37351#issuecomment-1200784741

   Of course, expectations need to be adjusted. Done, currently testing locally on scala-2.13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37351: [SPARK-38864][SQL][FOLLOW-UP] Make AnalysisException message deterministic
URL: https://github.com/apache/spark/pull/37351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org