You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/01 08:00:45 UTC
[GitHub] [rocketmq] Hen1ng opened a new issue #4083: The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.
Hen1ng opened a new issue #4083:
URL: https://github.com/apache/rocketmq/issues/4083
The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.
It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.
Generally, fixing an issue goes through the following steps:
1. Understand the issue reported;
1. Reproduce the unexpected behavior locally;
1. Perform root cause analysis to identify the underlying problem;
1. Create test cases to cover the identified problem;
1. Work out a solution to rectify the behavior and make the newly created test cases pass;
1. Make a pull request and go through peer review;
As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:
**BUG REPORT**
1. Please describe the issue you observed:
The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array. I dont know if there are some special purposes.
- What did you do (The steps to reproduce)?
- What is expected to see?
- What did you see instead?
3. Please tell us about your environment:
4. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
2. Provide any additional detail on your proposed use case for this feature.
2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
5. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:
- [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here,
- [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here,
- ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Hen1ng closed issue #4083: The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.
Posted by GitBox <gi...@apache.org>.
Hen1ng closed issue #4083:
URL: https://github.com/apache/rocketmq/issues/4083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Hen1ng commented on issue #4083: The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.
Posted by GitBox <gi...@apache.org>.
Hen1ng commented on issue #4083:
URL: https://github.com/apache/rocketmq/issues/4083#issuecomment-1086532905
ok ， thx for the answer. i will close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #4083: The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.
Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #4083:
URL: https://github.com/apache/rocketmq/issues/4083#issuecomment-1086525373
By designed, Because the last mappedFile is not full very likely, we can append data using it. If delete it, startOffset of new mappedFile will not keep sequence with deleted mappedFile, commitLog will has a hole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze edited a comment on issue #4083: The for loop in method org.apache.rocketmq.store.MappedFileQueue#deleteExpiredFileByTime can not reach the last one in the array.
Posted by GitBox <gi...@apache.org>.
ni-ze edited a comment on issue #4083:
URL: https://github.com/apache/rocketmq/issues/4083#issuecomment-1086525373
By designed, Because the last mappedFile is not full very likely, we can append data using it. If delete it, startOffset of new mappedFile will not keep sequence with deleted mappedFile, commitLog has a hole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org