You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by cl...@apache.org on 2013/11/15 21:34:11 UTC

svn commit: r1542386 - in /jena/Experimental/new-test: pom.xml src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java

Author: claude
Date: Fri Nov 15 20:34:10 2013
New Revision: 1542386

URL: http://svn.apache.org/r1542386
Log:
Updated failure messages for GraphContractTest
update POM to remove dependency on SNAPSHOT package.

Modified:
    jena/Experimental/new-test/pom.xml
    jena/Experimental/new-test/src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java

Modified: jena/Experimental/new-test/pom.xml
URL: http://svn.apache.org/viewvc/jena/Experimental/new-test/pom.xml?rev=1542386&r1=1542385&r2=1542386&view=diff
==============================================================================
--- jena/Experimental/new-test/pom.xml (original)
+++ jena/Experimental/new-test/pom.xml Fri Nov 15 20:34:10 2013
@@ -48,7 +48,7 @@
 		<dependency>
 			<groupId>org.xenei</groupId>
 			<artifactId>junit-contracts</artifactId>
-			<version>0.0.2-SNAPSHOT</version>
+			<version>0.0.2</version>
 			<!-- <scope>test</scope> -->
 		</dependency>
 	</dependencies>

Modified: jena/Experimental/new-test/src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java
URL: http://svn.apache.org/viewvc/jena/Experimental/new-test/src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java?rev=1542386&r1=1542385&r2=1542386&view=diff
==============================================================================
--- jena/Experimental/new-test/src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java (original)
+++ jena/Experimental/new-test/src/test/java/com/hp/hpl/jena/graph/GraphContractTest.java Fri Nov 15 20:34:10 2013
@@ -308,14 +308,14 @@ public class GraphContractTest<T extends
 				.handlesLiteralTyping()) {
 			Graph g1 = graphWith(getProducer().newInstance(),
 					"x P '1'xsd:integer");
-			assertTrue(g1.contains(x, P, node("'01'xsd:int")));
+			assertTrue(String.format( "literal type equality failed, does %s really implement literal typing", g1.getClass()),g1.contains(x, P, node("'01'xsd:int")));
 			//
 			Graph g2 = graphWith(getProducer().newInstance(), "x P '1'xsd:int");
-			assertTrue(g2.contains(x, P, node("'1'xsd:integer")));
+			assertTrue("Literal equality with '1'xsd:integer failed", g2.contains(x, P, node("'1'xsd:integer")));
 			//
 			Graph g3 = graphWith(getProducer().newInstance(),
 					"x P '123'xsd:string");
-			assertTrue(g3.contains(x, P, node("'123'")));
+			assertTrue("Literal equality with '123' failed", g3.contains(x, P, node("'123'")));
 		}
 	}
 
@@ -334,9 +334,9 @@ public class GraphContractTest<T extends
 
 		Graph g = graphWith(getProducer().newInstance(),
 				"s P o; _x _R _y; x S 0");
-		assertTrue(g.contains(s, P, o));
-		assertTrue(g.contains(_x, _R, _y));
-		assertTrue(g.contains(x, S, node("0")));
+		assertTrue("Graph should have contained s P o", g.contains(s, P, o));
+		assertTrue("Graph should have contained _x _R _y", g.contains(_x, _R, _y));
+		assertTrue("Graph should have contained x S 'O'", g.contains(x, S, node("0")));
 		/* */
 		assertFalse(g.contains(s, P, node("Oh")));
 		assertFalse(g.contains(S, P, node("O")));
@@ -405,14 +405,15 @@ public class GraphContractTest<T extends
 				.handlesLiteralTyping()) {
 			Graph g1 = graphWith(getProducer().newInstance(),
 					"x P '1'xsd:integer");
-			assertTrue(g1.contains(triple("x P '01'xsd:int")));
+			assertTrue( String.format( "did not find x P '01'xsd:int, does %s really implement literal typing", g1.getClass()),
+					g1.contains(triple("x P '01'xsd:int")));
 			//
 			Graph g2 = graphWith(getProducer().newInstance(), "x P '1'xsd:int");
-			assertTrue(g2.contains(triple("x P '1'xsd:integer")));
+			assertTrue("did not find x P '1'xsd:integer", g2.contains(triple("x P '1'xsd:integer")));
 			//
 			Graph g3 = graphWith(getProducer().newInstance(),
 					"x P '123'xsd:string");
-			assertTrue(g3.contains(triple("x P '123'")));
+			assertTrue("did not find x P '123'xsd:string",g3.contains(triple("x P '123'")));
 		}
 	}
 
@@ -586,7 +587,7 @@ public class GraphContractTest<T extends
 				fail(e.getMessage());
 			}
 			txnCommit(g);
-			assertEquals(
+			assertEquals(String.format( "Should have found 4 elements, does %s really implement literal typing", g.getClass()),
 					4,
 					iteratorToSet(
 							g.find(Node.ANY, P, NodeCreateUtils.create("42")))
@@ -700,7 +701,7 @@ public class GraphContractTest<T extends
 				fail(e.getMessage());
 			}
 			txnCommit(g);
-			assertEquals(
+			assertEquals(String.format( "Should have found 4 elements, does %s really implement literal typing", g.getClass()),
 					4,
 					iteratorToSet(
 							g.find(new Triple(Node.ANY, P, NodeCreateUtils