[GitHub] [guacamole-client] mike-jumper opened a new pull request #703: GUACAMOLE-1545: Ensure tunnel "onload" fires only for true state changes.

[GitBox <gi...@apache.org>]

mike-jumper opened a new pull request #703:
URL: https://github.com/apache/guacamole-client/pull/703


   This change corrects the behavior of the `onload` event for session recordings, which should only fire when the recording has finished loading.
   
   Prior to this change, `onload` would fire as soon as the recording started downloading _and_ after the recording finished loading. This is because the tunnel implementation preemptively calls `disconnect()` within `connect()` to ensure any established connection is torn down before initiating a new connection. With the tunnel state (incorrectly) initialized to `CONNECTING`, this resulted in an incorrect `onstatechange` for `CLOSED` at the beginning of all connections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman merged pull request #703: GUACAMOLE-1545: Ensure tunnel "onload" fires only for true state changes.

[GitBox <gi...@apache.org>]

necouchman merged pull request #703:
URL: https://github.com/apache/guacamole-client/pull/703


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org