You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/15 04:38:04 UTC

[GitHub] [helix] kaisun2000 opened a new issue #1274: fix flaky test TestAutoRebalancce

kaisun2000 opened a new issue #1274:
URL: https://github.com/apache/helix/issues/1274


   This one failed 3 times in github out of 10 logs examined.
   
   ```
       Thread.sleep(100);
       result = ClusterStateVerifier.verifyByPolling(
           new ExternalViewBalancedVerifier(_gZkClient, CLUSTER_NAME, TEST_DB), 10000, 100);
       Assert.assertTrue(result);    ---> this line fails.
   ```
   
   Maybe it did note wait log enough for this ExternalViewBalancedVerifie. Need to add a log for distinguish the failure cause.
   
   log:
   >2020-08-12T03:55:06.4705923Z [ERROR] testAutoRebalance(org.apache.helix.integration.rebalancer.TestAutoRebalance)  Time elapsed: 10.969 s  <<< FAILURE!
   2020-08-12T03:55:06.4710172Z java.lang.AssertionError: expected:<true> but was:<false>
   2020-08-12T03:55:06.4716402Z         at org.apache.helix.integration.rebalancer.TestAutoRebalance.testAutoRebalance(TestAutoRebalance.java:177)
   2020-08-12T03:55:06.4717251Z 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] jiajunwang commented on issue #1274: fix flaky test TestAutoRebalancce

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1274:
URL: https://github.com/apache/helix/issues/1274#issuecomment-849103391


   Close test unstable tickets since we have an automatic tracking mechanism https://github.com/apache/helix/pull/1757 now for tracking the most recent test issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] jiajunwang closed issue #1274: fix flaky test TestAutoRebalancce

Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1274:
URL: https://github.com/apache/helix/issues/1274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] kaisun2000 commented on issue #1274: fix flaky test TestAutoRebalancce

Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1274:
URL: https://github.com/apache/helix/issues/1274#issuecomment-700406536


   Wait longer before polling to cluster converge and using correct AutoRebalancer class with AutoRebalancer strategy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] kaisun2000 commented on issue #1274: fix flaky test TestAutoRebalancce

Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1274:
URL: https://github.com/apache/helix/issues/1274#issuecomment-674347957


   This could be similar to https://github.com/apache/helix/issues/1268. Though validation is not easy. Maybe by reducing the ExternalViewBalancedVerifier polling time out, if it fails consistently, we can confirm.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org