You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/22 07:02:06 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12842: fix(title): incorrect redirect when sublink is clicked.

plainheart opened a new pull request #12842:
URL: https://github.com/apache/incubator-echarts/pull/12842


   
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fixed #12841, which was brought by #12380.
   When `sublink` is cliked, a wrong link(should be `sublink`, but `link` in fact) will be opened. 
   
   ### Fixed issues
   
   - #12841
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12842: fix(title): incorrect redirect when sublink is clicked.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12842:
URL: https://github.com/apache/incubator-echarts/pull/12842#issuecomment-647330427


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart merged pull request #12842: fix(title): incorrect redirect when sublink is clicked.

Posted by GitBox <gi...@apache.org>.
plainheart merged pull request #12842:
URL: https://github.com/apache/incubator-echarts/pull/12842


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12842: fix(title): incorrect redirect when sublink is clicked.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12842:
URL: https://github.com/apache/incubator-echarts/pull/12842#issuecomment-647327449


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on pull request #12842: fix(title): incorrect redirect when sublink is clicked.

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12842:
URL: https://github.com/apache/incubator-echarts/pull/12842#issuecomment-647329829


   Sorry, My bad


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org