You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2016/05/18 11:46:47 UTC
[22/51] [abbrv] git commit: updated refs/heads/4.9-bountycastle-daan
to d8c42a9
Merge pull request #1453 from GabrielBrascher/brascher-removeUnusedClasses2
Remove classes with no referencesI used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse. With this tool, I discovered a lot of code without any reference (variables, methods and classes).
Following the work that was done at [https://github.com/apache/cloudstack/pull/1448]; this pull request had the goal of removing some of these classes. To check if I wasn't missing anything I searched for any file that could reference some of those classes. As I haven't found any way of these classes being used, they were removed. Note that some of them I found other references, but references such as commented lines or tests, nothing that could indicate their use (as XML files configuring beans or another class instantiating an object with "new").
Waiting for tests. Please tell me if I am missing something.
Removed Classes:
- org.apache.cloudstack.framework.jobs.JobCancellationException (**Note:** removed
variable JobCancellationException in com.cloud.utils.SerialVersionUID)
- org.apache.cloudstack.ldap.NoSuchLdapUserException (**Note:** removed test file
/cloud-plugin-user-authenticator-ldap/test/groovy/org/apache/cloudstack/ldap/NoSuchLdapUserExceptionSpec.groovy)
- com.cloud.agent.api.storage.CreateVolumeOVAAnswer
- com.cloud.exception.MissingParameterValueException
- org.apache.cloudstack.api.response.StatusResponse
- org.apache.cloudstack.api.response.VolumeDetailResponse
- org.apache.cloudstack.api.response.UpgradeVmResponse
- org.apache.cloudstack.api.response.AddIpToVmNicResponse
- org.apache.cloudstack.api.response.TemplateZoneResponse (**Note:** at
org.apache.cloudstack.api.response.TemplateResponse, there is this
comment "To avoid breaking backwards compatibility, we still treat a
template at different zones as different templates, so not embedding
template_zone information in this TemplateZoneResponse set. `private
Set<TemplateZoneResponse> zones;`" but right now it is not used)
- org.apache.cloudstack.api.response.NicDetailResponse
* pr/1453:
Removed classes with no reference
Signed-off-by: Will Stevens <wi...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/20cf8b23
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/20cf8b23
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/20cf8b23
Branch: refs/heads/4.9-bountycastle-daan
Commit: 20cf8b23c015fc2a6ba8d6ac4b086258ccf5236e
Parents: 3f97908 4179606
Author: Will Stevens <wi...@gmail.com>
Authored: Thu May 12 16:48:02 2016 -0400
Committer: Will Stevens <wi...@gmail.com>
Committed: Thu May 12 16:48:03 2016 -0400
----------------------------------------------------------------------
.../api/storage/CreateVolumeOVAAnswer.java | 26 --
.../api/storage/PrepareOVAPackingAnswer.java | 26 --
.../MissingParameterValueException.java | 26 --
.../api/response/AddIpToVmNicResponse.java | 88 -----
.../api/response/NicDetailResponse.java | 76 -----
.../cloudstack/api/response/StatusResponse.java | 34 --
.../api/response/TemplateResponse.java | 9 +-
.../api/response/TemplateZoneResponse.java | 134 --------
.../api/response/UpgradeVmResponse.java | 323 -------------------
.../api/response/VolumeDetailResponse.java | 76 -----
.../jobs/JobCancellationException.java | 46 ---
.../ldap/NoSuchLdapUserException.java | 31 --
.../ldap/NoSuchLdapUserExceptionSpec.groovy | 30 --
.../java/com/cloud/utils/SerialVersionUID.java | 1 -
14 files changed, 1 insertion(+), 925 deletions(-)
----------------------------------------------------------------------