You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/14 11:42:27 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4315: Properties refactor
kimmking opened a new pull request #4315: Properties refactor
URL: https://github.com/apache/incubator-shardingsphere/pull/4315
Fixes #4309.
Changes proposed in this pull request:
- refactor ShardingSphereProperties to support more than one enum class.
- add new interface TypedInterface and a class TypedProperties.
- fix related unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4315:
Properties refactor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4315: Properties refactor
URL: https://github.com/apache/incubator-shardingsphere/pull/4315#issuecomment-586273554
## Pull Request Test Coverage Report for [Build 1738](https://coveralls.io/builds/28734530)
* **41** of **46** **(89.13%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.003%**) to **61.317%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/constant/properties/TypedProperties.java](https://coveralls.io/builds/28734530/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconstant%2Fproperties%2FTypedProperties.java#L90) | 40 | 45 | 88.89%
<!-- | **Total:** | **41** | **46** | **89.13%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28734530/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L118) | 1 | 61.11% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28734530) |
| :-- | --: |
| Change from base [Build 858](https://coveralls.io/builds/28733914): | 0.003% |
| Covered Lines: | 11053 |
| Relevant Lines: | 18026 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4315:
Properties refactor
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4315: Properties refactor
URL: https://github.com/apache/incubator-shardingsphere/pull/4315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4315: Properties refactor
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4315: Properties refactor
URL: https://github.com/apache/incubator-shardingsphere/pull/4315#issuecomment-586273554
## Pull Request Test Coverage Report for [Build 1739](https://coveralls.io/builds/28734573)
* **41** of **46** **(89.13%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.009%**) to **61.323%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/constant/properties/TypedProperties.java](https://coveralls.io/builds/28734573/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconstant%2Fproperties%2FTypedProperties.java#L90) | 40 | 45 | 88.89%
<!-- | **Total:** | **41** | **46** | **89.13%** | -->
| Totals | [](https://coveralls.io/builds/28734573) |
| :-- | --: |
| Change from base [Build 858](https://coveralls.io/builds/28733914): | 0.009% |
| Covered Lines: | 11054 |
| Relevant Lines: | 18026 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services