You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by NewBoLing <gi...@git.apache.org> on 2017/05/20 12:03:44 UTC

[GitHub] spark pull request #18045: Update SVDPlusPlus.scala

GitHub user NewBoLing opened a pull request:

    https://github.com/apache/spark/pull/18045

    Update SVDPlusPlus.scala

    I think updated information of updateY incorrectly send to source vertice. the original code like the below.
          ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) * conf.gamma1))
          In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).  
          we have already updated the part of y in usr._2 through sending the message to destination vertex, and this method will effect the part of y in usr._2,
          but the part of pu is never updated. so we should send updateP to source vertex not updateY.
    
    ## What changes were proposed in this pull request?
    
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NewBoLing/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18045.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18045
    
----
commit 3c28883c55cc977d68d504805973877d3ea02e54
Author: NewBoLing <jj...@163.com>
Date:   2017-05-20T11:39:27Z

    Update SVDPlusPlus.scala
    
    I think updated information of updateY incorrectly send to source vertice. the original code like the below.
          ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) * conf.gamma1))
          In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).  
          we have already updated the part of y in usr._2 through sending the message to destination vertex, and this method will effect the part of y in usr._2,
          but the part of pu is never updated. so we should send updateP to source vertex not updateY.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18045: Update SVDPlusPlus.scala

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18045
  
    Please read http://spark.apache.org/contributing.html and fix the title
    Does it make sense to send updateP twice?
    Maybe @ankurdave can return to comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18045: Update SVDPlusPlus.scala

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18045
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18045: [Spark18045][MLlib]updated the information sendin...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/18045


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org