[GitHub] [flink] zoltar9264 commented on a diff in pull request #20093: [FLINK-28172][changelog] Scatter dstl files into separate directories…

[GitBox <gi...@apache.org>]

zoltar9264 commented on code in PR #20093:
URL: https://github.com/apache/flink/pull/20093#discussion_r910585869


##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java:
##########
@@ -54,6 +55,8 @@
 public class StateChangeFsUploader implements StateChangeUploader {
     private static final Logger LOG = LoggerFactory.getLogger(StateChangeFsUploader.class);
 
+    private static final String DSTL_SUB_PATH = "%s/dstl";
+

Review Comment:
   This purpose is described in the last paragraph of the [FLINK-28172](https://issues.apache.org/jira/browse/FLINK-28172).
   
   > Going a step further, we can even create two levels of subdirectories under the dstl.dfs.base-path directory, like base-path/{jobId}/dstl . This way, if the user configures the same dstl.dfs.base-path as state.checkpoints.dir, all files needed for job recovery will be in the same directory and well organized.
   
   WDYT ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org