You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/26 03:06:29 UTC
[GitHub] xuanyuanking commented on a change in pull request #23827:
[SPARK-26912][CORE][HISTORY] Allow setting permission for event_log
xuanyuanking commented on a change in pull request #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log
URL: https://github.com/apache/spark/pull/23827#discussion_r260108868
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -83,6 +83,11 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val EVENT_LOG_PERMISSION =
+ ConfigBuilder("spark.eventLog.permission")
+ .stringConf
Review comment:
Better to add `doc` here and fill in the detailed illustration of the usage and default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org