You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/01/10 14:57:46 UTC

[jira] Updated: (CASSANDRA-1937) Keep partitioned counters ("contexts") sorted

     [ https://issues.apache.org/jira/browse/CASSANDRA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-1937:
----------------------------------------

    Attachment: 0001-Keep-counter-partitioned-context-sorted.patch

Patch attached. Most notable change: thanks to the sorting, I rewrote CounterContext.merge() to avoid creating a hashmap and thus keep garbage to a minimum.

> Keep partitioned counters ("contexts") sorted
> ---------------------------------------------
>
>                 Key: CASSANDRA-1937
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1937
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8
>
>         Attachments: 0001-Keep-counter-partitioned-context-sorted.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> In the value of CounterColumns, the code keep the subpart unsorted, but sort
> them 'on the fly' when needed (in diff() and merge()). It will be more
> efficient to keep the parts always sorted (it will also be easier in that it
> will remove the need of the ad-hoc in-place quicksort in CounterContext).
> NOTE: this breaks the on-disk file format (for counters)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.