You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/02/02 10:41:26 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/683
ZEPPELIN-646: Shell interpreter output streaming
### What is this PR for?
After #611 merged, Zeppelin provides streaming output for **spark** and **pyspark** interpreter. For the improvement, I changed a few code lines using <code>[InterpreterContext](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterContext.java#L66)</code> so that **sh** interpreter can be available too.
### What type of PR is it?
Improvement
### Todos
### Is there a relevant Jira issue?
[ZEPPELIN-646: Shell interpreter output streaming](https://issues.apache.org/jira/browse/ZEPPELIN-646)
[ZEPPELIN-554: Streaming interpreter output to front-end]()
### How should this be tested?
After applying this PR, run this below code with `sh` interpreter in Zeppelin.
```
date && sleep 3 && date
```
Then you can see two timestamps which have 3 seconds gap.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-646
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/683.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #683
----
commit a9d2e2b4a9a4132cc1b2e0a8972a8eb2c6c8d3f3
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-02-02T09:25:20Z
ZEPPELIN-646: Shell interpreter output streaming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-178815547
After some search, it seems that the streaming output wasn't documented anywhere.
That could be valuable information for those making interpreter, but also to show possible streaming ability of Zeppelin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-179028408
cool @dArKmAn1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell
interpreter o...
Posted by Sourav Mazumder <so...@gmail.com>.
One issue I found with the shell interpreter is secuity issue. The user who
is using the shell interpreter from the Zeppelin has the same security
permission as of the user who has started the Zeppelin process. So the user
from Zepeelin can run any executable, see the data etc.
For that reason I had to disable this shell interpreter in few deployments.
This again tells why Zeppelin level authentication is really very
important. Or at least at the Shell Interpreter level a basic
authentication should be added.
Regards,
Sourav
On Fri, Feb 5, 2016 at 11:57 AM, Leemoonsoo <gi...@git.apache.org> wrote:
> Github user Leemoonsoo commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-180534051
>
> Yes it would be nice to document how to use InterpreterOutput when
> writing interpreter.
> Maybe, the document can even link this PR's file diff to show how to
> change interpreter to leverage InterpreterOutput, as an example.
>
> Anyway, LGTM
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-180534051
Yes it would be nice to document how to use InterpreterOutput when writing interpreter.
Maybe, the document can even link this PR's file diff to show how to change interpreter to leverage InterpreterOutput, as an example.
Anyway, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-180678841
@Leemoonsoo Make sense. Then i'll add that content you mentioned in the docs : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-178954104
@corneadoug Make sense. Then I'll write a new docs for ability of Zeppelin streaming output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-646: Shell interpreter o...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/683#issuecomment-180703314
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---