[GitHub] [incubator-superset] rusackas commented on a change in pull request #11395: refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11395:
URL: https://github.com/apache/incubator-superset/pull/11395#discussion_r510466263



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -199,43 +214,17 @@ class DatasourceControl extends React.PureComponent {
                 }`}
               />
             </Label>
-          </OverlayTrigger>
-          <TooltipWrapper
-            label="change-datasource"
-            tooltip={t('More dataset related options')}
-            trigger={['hover']}
+          </Tooltip>
+          <Dropdown
+            overlay={datasourceMenu}
+            trigger={['click']}
+            id="datasource_menu"

Review comment:
       Actually there are some styles for that, in DatasourceControl.less. @kgabryje would you mind seeing if those styles are still necessary/relevant? If they are, this may be the right opportunity to bring them into the component with Emotion Theme variables wired in. One less LESS file!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org