[jira] [Commented] (CB-6889) "Edit json" step in master.cfg fails on Windows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14024672#comment-14024672 ] 

ASF GitHub Bot commented on CB-6889:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-medic/pull/10

    CB-6889 "Edit json" step in master.cfg fails on Windows

    When running medic on windows (either the client and server or just a client), the Edit json step specified in master.cfg fails.
    *Reason:* Windows medic install uses the unix utilities from git\bin, the version of sed installed requires specification of backup suffix for -i option without space.
    ```
      -i[SUFFIX], --in-place[=SUFFIX]
                     edit files in place (makes backup if extension supplied)
    ```
    from sed help.
    
    Fix for [CB-6889](https://issues.apache.org/jira/browse/CB-6889)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-medic CB-6889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-medic/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 69a6ae92ced92c51cf12ec83b180a24308881bd0
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-06-09T11:51:50Z

    Change "-i" sed's argument behaviour, which now works on both mac and windows.

----


> "Edit json" step in master.cfg fails on Windows
> -----------------------------------------------
>
>                 Key: CB-6889
>                 URL: https://issues.apache.org/jira/browse/CB-6889
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows 8, WP8
>            Reporter: Vladimir Kotikov
>            Assignee: Jesse MacFadyen
>
> When running medic on windows (either the client and server or just a client), the Edit json step specified in master.cfg fails.
> Reason: Windows medic install uses the unix utilities from git\bin, the version of sed installed requires specification of backup suffix for {{-i}} option without space.
> {noformat}
>   -i[SUFFIX], --in-place[=SUFFIX]
>                  edit files in place (makes backup if extension supplied)
> {noformat}
> from sed help.
> {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -ibak package.json}} instead of {{sed -e 's/cordova-lib": "0./cordova-lib": ">=0./' -i bak package.json}} works fine on both windows and mac.



--
This message was sent by Atlassian JIRA
(v6.2#6252)