You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/07 13:00:47 UTC

[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #1048: apps: update licenses to Apache

jerpelea opened a new pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048


   ## Summary
   Gregory Nutt has submitted the SGA and  Haltian Ltd has submitted the SGA
   
   as a result we can migrate the licenses to Apache.
   
   ## Impact
   LICENSE
   
   ## Testing
   NONE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1048: apps: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048#discussion_r820744203



##########
File path: examples/calib_udelay/calib_udelay_main.c
##########
@@ -260,11 +260,11 @@ int main(int argc, FAR char *argv[])
        loop_count += min_step * calibration_step_multiplier)
     {
       duration += (double)num_measurements * loop_count *
-                          timer_resolution * min_timer_resolution_steps / min_step;
+                timer_resolution * min_timer_resolution_steps / min_step;
     }
 
-  printf("Performing main calibration for udelay. This will take approx. %.3f seconds.\n",
-         duration * 1e-9);
+  printf("Performing main calibration for udelay."
+         "This will take approx. %.3f seconds.\n", duration * 1e - 9);

Review comment:
       Does compiler interpret to (duration * 1e) - 9?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1048: apps: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048#issuecomment-1060675598


   @jerpelea should we fix the style too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1048: apps: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] jerpelea edited a comment on pull request #1048: apps: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048#issuecomment-1060700622


   @xiaoxiang781216 I always do it, when it makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #1048: apps: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1048:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1048#issuecomment-1060700622


   @xiaoxiang781216 I always do it in, when it makes sense, a separate patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org