You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by isapir <gi...@git.apache.org> on 2017/10/02 20:06:35 UTC

[GitHub] tomcat issue #74: added javadoc comment

Github user isapir commented on the issue:

    https://github.com/apache/tomcat/pull/74
  
    @markt-asf - What do you think about changing `FilterBase` so that it extends `javax.servlet.GenericFilter`?  That way we can use methods like `getInitParameter()` and have a single base class and "cleaner" code.
    
    For example, ATM some filters extend `org.apache.catalina.filters.FilterBase` (e.g. ExpiresFilter, FailedRequestFilter) and others extend `javax.servlet.GenericFilter` (e.g. CorsFilter, RemoteIpFilter).
    
    I can provide a patch if you agree.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org