You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/15 01:56:10 UTC
[GitHub] [ozone] vivekratnavel opened a new pull request #2334: HDDS-4692. Handle CRLStatusReport got from DN heartbeats and persist them
vivekratnavel opened a new pull request #2334:
URL: https://github.com/apache/ozone/pull/2334
## What changes were proposed in this pull request?
- Add a heartbeat handler for CRLStatusReport received from DNs
- Store CRL Status of each DN in SCM (in memory)
- Add unit tests
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4692
## How was this patch tested?
Added unit tests to test the report processing part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel merged pull request #2334: HDDS-4692. Handle CRLStatusReport got from DN heartbeats and persist them
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #2334:
URL: https://github.com/apache/ozone/pull/2334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2334: HDDS-4692. Handle CRLStatusReport got from DN heartbeats and persist them
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2334:
URL: https://github.com/apache/ozone/pull/2334#discussion_r652285043
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/crl/CRLStatus.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.hadoop.hdds.security.x509.crl;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+
+import java.util.List;
+
+/**
+ * Class that contains the CRL status.
+ */
+public class CRLStatus {
+ private final long receivedCRLId;
+ private final List<Long> pendingCRLIds;
+
+ /**
+ * Constructs a CRL Status.
+ * @param receivedCRLId The last received CRL id.
+ * @param pendingCRLIds A list of CRL Ids that are pending processing.
+ */
+ public CRLStatus(long receivedCRLId, List<Long> pendingCRLIds) {
+ this.receivedCRLId = receivedCRLId;
+ this.pendingCRLIds = pendingCRLIds;
+ }
+
+
+ public long getReceivedCRLId() {
+ return receivedCRLId;
+ }
+
+ public List<Long> getPendingCRLIds() {
+ return pendingCRLIds;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (!(obj instanceof CRLStatus)) {
+ return false;
+ }
+
+ CRLStatus that = (CRLStatus) obj;
+
+ if (this.receivedCRLId != that.getReceivedCRLId()) {
+ return false;
+ }
+ if (this.pendingCRLIds.size() != that.getPendingCRLIds().size()) {
+ return false;
+ }
+
+ return CollectionUtils.isEqualCollection(this.pendingCRLIds,
+ that.getPendingCRLIds());
+ }
+
+ @Override
+ public int hashCode() {
+ return new HashCodeBuilder(81, 145)
+ .append(receivedCRLId)
+ .append(pendingCRLIds)
+ .toHashCode();
+ }
+
+ @Override
+ public String toString() {
+ return "CRLStatus{" +
+ ", receivedCRLId=" + receivedCRLId +
+ ", pendingCRLIds=" + pendingCRLIds +
Review comment:
can we expand the pendingCRLIds here?
e.g., StringUtils.join(pendingCRLIds, ",")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel merged pull request #2334: HDDS-4692. Handle CRLStatusReport got from DN heartbeats and persist them
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #2334:
URL: https://github.com/apache/ozone/pull/2334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org