[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2224: LUCENE-9681: Hunspell spellchecker: support numbers with separators

[GitBox <gi...@apache.org>]

donnerpeter commented on a change in pull request #2224:
URL: https://github.com/apache/lucene-solr/pull/2224#discussion_r561804052



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##########
@@ -51,6 +57,28 @@ public boolean spell(String word) {
     return false;
   }
 
+  private static boolean isNumber(String s) {
+    int i = 0;
+    while (i < s.length()) {

Review comment:
       My goal is to have a drop-in replacement for Hunspell (at least for some languages), so I wouldn't generalize its behavior for now. Maybe later, and preferably accompanied by corresponding changes in native Hunspell.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org