You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/30 03:45:18 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #8743: [bot-cherry-pick][WebSocket] Fix the initial sequence id error

codelipenghui opened a new pull request #8743:
URL: https://github.com/apache/pulsar/pull/8743


   ### Motivation
   
   The WebSocket `ProducerHandler` parse a wrong string so the client's query param `initialSequenceId` will always fail.
   
   ### Modifications
   
   - Parse the real `initialSequenceId` value.
   - Add unit tests to ensure that all params from the WebSocket url can be converted to the right config.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   (cherry picked from commit be39f502de0f5055c6db1b9d3688abd25d9ccc0f)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8743: [bot-cherry-pick][WebSocket] Fix the initial sequence id error

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8743:
URL: https://github.com/apache/pulsar/pull/8743#issuecomment-737145543


   Hey. If you want to cherry-pick this pr to a target branch, please comments '/pulsarbot cherry-pick to branch-x.y'.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #8743: [bot-cherry-pick][WebSocket] Fix the initial sequence id error

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8743:
URL: https://github.com/apache/pulsar/pull/8743


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org