You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/06/10 12:39:53 UTC

[tomcat] branch main updated: Silence new false positives

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new ae50fbcf70 Silence new false positives
ae50fbcf70 is described below

commit ae50fbcf70740f0d54cb4e96e66e1d5952e4a364
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Jun 10 13:39:33 2022 +0100

    Silence new false positives
---
 res/spotbugs/filter-false-positives.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 85ca2a707a..ef68d4b4bb 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -395,6 +395,12 @@
     </Or>
     <Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
   </Match>
+  <Match>
+    <!-- Use of == rather than equals() is deliberate. -->
+    <Class name="org.apache.catalina.realm.DigestCredentialHandlerBase"/>
+    <Method name="equals"/>
+    <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ"/>
+  </Match>
   <Match>
     <!-- Random will be SecureRandom and will be used multiple times. -->
     <Class name="org.apache.catalina.realm.DigestCredentialHandlerBase"/>
@@ -1419,6 +1425,12 @@
     <Method name="URLDecode"/>
     <Bug code="Dm" />
   </Match>
+  <Match>
+    <!-- Not an issue. Initialisation is as intended. -->
+    <Class name="org.apache.tomcat.util.compat.JreCompat"/>
+    <Method name="&lt;clinit&gt;"/>
+    <Bug pattern="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION" />
+  </Match>
   <Match>
     <!-- URLs used are always provided by the container so would normally be -->
     <!-- file URLs.                                                          -->


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org