You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Murtadha Hubail (Code Review)" <de...@asterixdb.apache.org> on 2019/06/07 03:39:07 UTC
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3430
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
[NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- To avoid cases where unintentional false comparison result happens
due to a relative path of one FileReference starting with "/" and
the other's does not, use the file absolute path in hashCode and
equals.
Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
---
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/30/3430/1
diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
index 4ded855..e4097ff 100644
--- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
+++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
@@ -58,12 +58,12 @@
if (!(o instanceof FileReference)) {
return false;
}
- return path.equals(((FileReference) o).path) && dev.equals(((FileReference) o).dev);
+ return file.getAbsolutePath().equals(((FileReference) o).getAbsolutePath());
}
@Override
public int hashCode() {
- return path.hashCode();
+ return file.getAbsolutePath().hashCode();
}
/**
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1253/ (5/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/103/ (12/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:24 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9844/ (3/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8665/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:40:31 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1064/ (7/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:16 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5907/ (10/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:20 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5867/ (11/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:22 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Murtadha Hubail (Code Review)" <de...@asterixdb.apache.org>.
Murtadha Hubail has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
[NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- To avoid cases where unintentional false comparison result happens
due to a relative path of one FileReference starting with "/" and
the other's does not, use the file absolute path in hashCode and
equals.
Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3430
Reviewed-by: Michael Blow <mb...@apache.org>
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Anon. E. Moose (1000171):
diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
index 4ded855..e4097ff 100644
--- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
+++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/FileReference.java
@@ -58,12 +58,12 @@
if (!(o instanceof FileReference)) {
return false;
}
- return path.equals(((FileReference) o).path) && dev.equals(((FileReference) o).dev);
+ return file.getAbsolutePath().equals(((FileReference) o).getAbsolutePath());
}
@Override
public int hashCode() {
- return path.hashCode();
+ return file.getAbsolutePath().hashCode();
}
/**
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5803/ (1/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:14 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Michael Blow (Code Review)" <de...@asterixdb.apache.org>.
Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:54:00 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6468/ (6/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:16 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Murtadha Hubail (Code Review)" <de...@asterixdb.apache.org>.
Murtadha Hubail has removed a vote on this change.
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Removed Code-Review-2 by Murtadha Hubail <mh...@apache.org>
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11377/ (8/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:17 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1: Contrib+1
Analytics Compatibility Tests Successful
https://cbjenkins.page.link/J7EjaHQuiUhdkL5PA : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:15:43 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Murtadha Hubail (Code Review)" <de...@asterixdb.apache.org>.
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1: Code-Review-2
Holding off the merge of this change.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Comment-Date: Wed, 12 Jun 2019 20:21:06 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/DgfYF79C3gaxjt9F8 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:44:15 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6108/ (4/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:15 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6258/ (2/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:14 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5884/ (9/12)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 07 Jun 2019 03:39:18 +0000
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3430 )
Change subject: [NO ISSUE][OTH] Use Absolute Path in FileReference hashCode/equals
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8665/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb642b3c5396a8319dc0aaf050e8af6fca93039
Gerrit-Change-Number: 3430
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:03:12 +0000
Gerrit-HasComments: No