[GitHub] [dolphinscheduler] cadl commented on issue #10288: [Feature] Make SERIAL_WAIT/SERIAL_DISCARD/SERIAL_PRIORITY work across multiple process instance versions

[GitBox <gi...@apache.org>]

cadl commented on issue #10288:
URL: https://github.com/apache/dolphinscheduler/issues/10288#issuecomment-1334708421

   > > After some research, I found the behavior of serial execution was changed at #9869.
   > > In the first version #6185, serial execution works on all process instances.
   > > After the #9869, SERIAL_WAIT/SERIAL_DISCARD/SERIAL_PRIORITY only works on the same version process instances.
   > > To fix this issue, I have 2 ideas:
   > > 
   > > 1. Recover the serial execution logic back to [[Feature-#6268][server-master] Serial execte process #6185](https://github.com/apache/dolphinscheduler/pull/6185). But also need to fix [[Bug-BE] Task flow definition cannot execute serial task flow while parallel serial alternate running. #9868](https://github.com/apache/dolphinscheduler/issues/9868), such as applying the [commit](https://github.com/apache/dolphinscheduler/pull/9869/commits/8b6363d2d38b961105202e0c4b405fc511f2ad56)
   > > 2. Based on 1, add `VERSIONING_SERIAL_WAIT/VERSIONING_SERIAL_DISCARD/VERSIONING_SERIAL_PRIORITY`.
   > > 
   > > I prefer the first one.
   > > Can you give me any advice?
   > > cc @SbloodyS @WangJPLeo @caishunfeng
   > 
   > I agree wit @caishunfeng, i think the real role of a workflow definition is to provide a portal to create workflow instances, each version may be slightly different or the core content may be different, and each version is a separate entity. So using a certain version of the strategy to affect other versions, it does not seem appropriate.
   
   Hi @WangJPLeo @caishunfeng  , thanks for your replies.  
   
   Looks like in current codebase, once processDefine is updated, the `version` will change. If each version is a separate entity, then the decision of whether to update the `version` should be left to the user.  Otherwise there is no way for the user to keep the processDefine as a "same entity" while being "harmless updated"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org