[GitHub] [iceberg] rdblue commented on a change in pull request #1318: Add equality field IDs to DeleteFile

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1318:
URL: https://github.com/apache/iceberg/pull/1318#discussion_r468870977



##########
File path: api/src/main/java/org/apache/iceberg/ContentFile.java
##########
@@ -97,6 +97,17 @@
    */
   List<Long> splitOffsets();
 
+  /**
+   * Returns the set of field IDs used for equality comparison, in equality delete files.
+   * <p>
+   * An equality delete file may contain additional data fields that are not used by equality
+   * comparison. The subset of columns in a delete file to be used in equality comparison are
+   * tracked by ID. Extra columns can be used to

Review comment:
       Fixed. Thanks!

##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -385,7 +399,24 @@ public String toString() {
         .add("lower_bounds", lowerBounds)
         .add("upper_bounds", upperBounds)
         .add("key_metadata", keyMetadata == null ? "null" : "(redacted)")
-        .add("split_offsets", splitOffsets == null ? "null" : splitOffsets)
+        .add("split_offsets", splitOffsets == null ? "null" : splitOffsets())
+        .add("equality_ids", equalityIds == null ? "null" : equalityFieldIds())
         .toString();
   }
+
+  private static int[] toIntArray(List<Integer> ints) {

Review comment:
       Moved to `ArrayUtil`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org