You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by kishorekasi <gi...@git.apache.org> on 2017/06/09 07:12:43 UTC
[GitHub] bookkeeper pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper
GitHub user kishorekasi opened a pull request:
https://github.com/apache/bookkeeper/pull/183
BOOKKEEPER-588 SSL Support for Bookkeeper
+ Merged changes from @eoliville
+ Mutual Authentication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorekasi/bookkeeper BOOKKEEPER-588-kishore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 1105ea825707c2b8301285de7ec0db8f06dcfa09
Author: Kishore Kasi Udayashankar <ku...@salesforce.com>
Date: 2017-02-13T19:59:22Z
BOOKKEEPER-588 SSL Support for Bookkeeper
+ Merged changes from @eoliville
+ Mutual Authentication
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/183
fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
@sijie for me this patch is OK, I don't know if other developers/committer want to add other comments
@kishorekasi can you change the description of the PR which usually it written to "git log" to remove the (wrong) reference to my github account and add a reference to @ivankelly which was the original author of the patch ?
We will need to add the documentation to the security docs, maybe we can do it after committing the general introduction to "security" which I am working on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by kishorekasi <gi...@git.apache.org>.
Github user kishorekasi commented on the issue:
https://github.com/apache/bookkeeper/pull/183
Updated the pull request. I am not able to reproduced the previous jenkins failure locally. With this new update I will wait for the jenkins run to check if the failures are repeatable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
I wonder if we have to add some "stat" about SSL clients. Maybe we can enhance this aspect in the future
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/183
@eolivelli I will try to go through this again.
/cc @merlimat for reviewing as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/183
Overall is ok,
but rat is failing and on jenkins one of the new tests failed, the mixed cluster one
Can you fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---