[GitHub] [incubator-druid] leventov commented on a change in pull request #8373: Speed up ExpressionSelectors.makeExprEvalSelector

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8373: Speed up ExpressionSelectors.makeExprEvalSelector
URL: https://github.com/apache/incubator-druid/pull/8373#discussion_r318618017
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
 ##########
 @@ -338,8 +336,8 @@ public BindingDetails withScalarArguments(Set<Expr> scalarArguments)
     {
       Set<IdentifierExpr> moreScalars = new HashSet<>();
       for (Expr expr : scalarArguments) {
-        final IdentifierExpr stringIdentifier = expr.getIdentifierExprIfIdentifierExpr();
-        if (stringIdentifier != null) {
+        final boolean isIdentiferExpr = expr.getIdentifierExprIfIdentifierExpr() != null;
+        if (isIdentiferExpr) {
 
 Review comment:
   @ccaominh this inspection is always a false-positive. I think it's worth disabling it in the Druid config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org