You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/08/12 13:37:24 UTC

svn commit: r1372071 - /lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java

Author: rmuir
Date: Sun Aug 12 11:37:24 2012
New Revision: 1372071

URL: http://svn.apache.org/viewvc?rev=1372071&view=rev
Log:
re-enable test

Modified:
    lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java

Modified: lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java?rev=1372071&r1=1372070&r2=1372071&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java (original)
+++ lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java Sun Aug 12 11:37:24 2012
@@ -69,16 +69,12 @@ public class TestReaderClosed extends Lu
   }
 
   // LUCENE-3800
-  @BadApple
-  @AwaitsFix(bugUrl = "LUCENE-4280")
   public void testReaderChaining() throws Exception {
     assertTrue(reader.getRefCount() > 0);
     IndexReader wrappedReader = SlowCompositeReaderWrapper.wrap(reader);
     wrappedReader = new ParallelAtomicReader((AtomicReader) wrappedReader);
 
-    // TODO: LUCENE-4280; this fails:
     IndexSearcher searcher = newSearcher(wrappedReader);
-    // but with this it works: IndexSearcher searcher = new IndexSearcher(wrappedReader);
 
     TermRangeQuery query = TermRangeQuery.newStringRange("field", "a", "z", true, true);
     searcher.search(query, 5);
@@ -90,6 +86,9 @@ public class TestReaderClosed extends Lu
         "this IndexReader cannot be used anymore as one of its child readers was closed",
         ace.getMessage()
       );
+    } finally {
+      // shutdown executor: in case of wrap-wrap-wrapping
+      searcher.getIndexReader().close();
     }
   }