You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2016/11/29 13:03:15 UTC

Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
  ambari-web/app/data/HDP2/site_properties.js d61d4aa 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.

> On Dec. 4, 2016, 12:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml, line 185
> > <https://reviews.apache.org/r/54161/diff/4-5/?file=1571968#file1571968line185>
> >
> >     maybe you could add an example in the description for the principal and the keytab (if they are empty by default)
> 
> Oliver Szabo wrote:
>     one more thing, is this change needed fog logfeeder as well? (addding these properties)

I've added separete logfeeder kerberos principal/keytab for external solr.
The description is the same as for "normal" kerberos keytab/principal, I don't see why do we need an example of a file path.


- Miklos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157921
-----------------------------------------------------------


On Dec. 5, 2016, 10:11 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 10:11 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml ee885e3 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.

> On Dec. 4, 2016, 12:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml, line 185
> > <https://reviews.apache.org/r/54161/diff/4-5/?file=1571968#file1571968line185>
> >
> >     maybe you could add an example in the description for the principal and the keytab (if they are empty by default)

one more thing, is this change needed fog logfeeder as well? (addding these properties)


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157921
-----------------------------------------------------------


On Dec. 4, 2016, 12:10 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 12:10 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.

> On Dec. 4, 2016, 12:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2, line 24
> > <https://reviews.apache.org/r/54161/diff/4/?file=1571973#file1571973line24>
> >
> >     why is it changed to infra solr? its not strictly infra solr right? fromm logsearch point of view its logsearch solr znode

sorry you did the right change. i thought the change is opposite


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157921
-----------------------------------------------------------


On Dec. 4, 2016, 12:10 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 12:10 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157921
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml (line 185)
<https://reviews.apache.org/r/54161/#comment228569>

    maybe you could add an example in the description for the principal and the keytab (if they are empty by default)



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 (line 24)
<https://reviews.apache.org/r/54161/#comment228568>

    why is it changed to infra solr? its not strictly infra solr right? fromm logsearch point of view its logsearch solr znode


- Oliver Szabo


On Dec. 4, 2016, 12:10 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 12:10 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157996
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Dec. 5, 2016, 2:46 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml ee885e3 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review158346
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Dec. 5, 2016, 2:46 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml ee885e3 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
>   ambari-web/app/data/HDP2/site_properties.js 5b66506 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 2:46 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
-------

example added to external kerberos principal/keytab


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml ee885e3 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
  ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
  ambari-web/app/data/HDP2/site_properties.js 5b66506 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 10:11 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
-------

Add separate logfeeder kerberos principal/keytab for external solr


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml ee885e3 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
  ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
  ambari-web/app/data/HDP2/site_properties.js 5b66506 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Dec. 4, 2016, 12:10 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
-------

Add properties to configure external kerberos principal/keytab


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f69bd3c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py d086f9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 9582334 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 062d636 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4f0a9d0 
  ambari-server/src/test/python/stacks/2.4/configs/default.json a6e2478 
  ambari-web/app/data/HDP2/site_properties.js 5b66506 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 2:25 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4854514 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
  ambari-web/app/data/HDP2/site_properties.js d61d4aa 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 2:10 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
-------

include stack_advisor.py changes too, the modifications of this file was missing from the patch by accident


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4854514 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
  ambari-web/app/data/HDP2/site_properties.js d61d4aa 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 1:36 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
-------

request restart if AMBARI_INFRA configuration changes


Bugs: AMBARI-19012
    https://issues.apache.org/jira/browse/AMBARI-19012


Repository: ambari


Description
-------

Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
  ambari-web/app/data/HDP2/site_properties.js d61d4aa 

Diff: https://reviews.apache.org/r/54161/diff/


Testing
-------

Tested on local cluster.


Thanks,

Miklos Gergely


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.

> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, line 132
> > <https://reviews.apache.org/r/54161/diff/1/?file=1571883#file1571883line132>
> >
> >     I think stack advisor changes are missing. at least it would be nice if it reccommend us some configuration in case we do not have infra-solr
> 
> Miklos Gergely wrote:
>     I don't see what could we recommend. Also the empty fields and the notification for the missing properties will remind the user that they must fill these fields with the external solr's ZK.
> 
> Oliver Szabo wrote:
>     like we could not know the number of external solr instances, so the maximum number of shards should be high (like 100), and the actual value should be 1.
> 
> Oliver Szabo wrote:
>     also it would be a good idea, if there is no zookeeper or ambari-infra on the cluster, stack advisor should "turn on" the external solr enabled property

It's already included, take a look at ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py line 1031


- Miklos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------


On Nov. 29, 2016, 2:25 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4854514 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.

> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, line 132
> > <https://reviews.apache.org/r/54161/diff/1/?file=1571883#file1571883line132>
> >
> >     I think stack advisor changes are missing. at least it would be nice if it reccommend us some configuration in case we do not have infra-solr
> 
> Miklos Gergely wrote:
>     I don't see what could we recommend. Also the empty fields and the notification for the missing properties will remind the user that they must fill these fields with the external solr's ZK.

like we could not know the number of external solr instances, so the maximum number of shards should be high (like 100), and the actual value should be 1.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------


On Nov. 29, 2016, 1:36 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Miklos Gergely <mg...@hortonworks.com>.

> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, line 132
> > <https://reviews.apache.org/r/54161/diff/1/?file=1571883#file1571883line132>
> >
> >     I think stack advisor changes are missing. at least it would be nice if it reccommend us some configuration in case we do not have infra-solr

I don't see what could we recommend. Also the empty fields and the notification for the missing properties will remind the user that they must fill these fields with the external solr's ZK.


- Miklos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------


On Nov. 29, 2016, 1:36 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.

> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, line 132
> > <https://reviews.apache.org/r/54161/diff/1/?file=1571883#file1571883line132>
> >
> >     I think stack advisor changes are missing. at least it would be nice if it reccommend us some configuration in case we do not have infra-solr
> 
> Miklos Gergely wrote:
>     I don't see what could we recommend. Also the empty fields and the notification for the missing properties will remind the user that they must fill these fields with the external solr's ZK.
> 
> Oliver Szabo wrote:
>     like we could not know the number of external solr instances, so the maximum number of shards should be high (like 100), and the actual value should be 1.

also it would be a good idea, if there is no zookeeper or ambari-infra on the cluster, stack advisor should "turn on" the external solr enabled property


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------


On Nov. 29, 2016, 2:25 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 4854514 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml (line 160)
<https://reviews.apache.org/r/54161/#comment227772>

    I think its possible that different KDC is used for different cluster so for that we will need external properties for principal/keytab etc.



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
<https://reviews.apache.org/r/54161/#comment227770>

    maybe we can keep this here, i mean if there is infra-solr installed, maybe that is used. (if there is no infra-solr on the cluster then i guess it wont have any effect)



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py (line 114)
<https://reviews.apache.org/r/54161/#comment227773>

    I think stack advisor changes are missing. at least it would be nice if it reccommend us some configuration in case we do not have infra-solr


- Oliver Szabo


On Nov. 29, 2016, 1:03 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:03 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external server instead. If AMBARI_INFRA is present then the user may choose to use it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 8257022 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml c5b9b4e 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 6d1cf38 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 6c1a936 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 2818708 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 eb7306c 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json 0193689 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>