You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/10/21 23:24:19 UTC

Review Request 26997: Adding quota check into scheduleCronJob RPC.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Bugs: AURORA-824
    https://issues.apache.org/jira/browse/AURORA-824


Repository: aurora


Description
-------

Adding quota check into scheduleCronJob.

Also, added missing tests for cron-related RPCs.


Diffs
-----

  build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 

Diff: https://reviews.apache.org/r/26997/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57662
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 21, 2014, 2:24 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26997/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 2:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-824
>     https://issues.apache.org/jira/browse/AURORA-824
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding quota check into scheduleCronJob.
> 
> Also, added missing tests for cron-related RPCs.
> 
> 
> Diffs
> -----
> 
>   build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 
> 
> Diff: https://reviews.apache.org/r/26997/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 4 p.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
-------

CR comments.


Bugs: AURORA-824
    https://issues.apache.org/jira/browse/AURORA-824


Repository: aurora


Description
-------

Adding quota check into scheduleCronJob.

Also, added missing tests for cron-related RPCs.


Diffs (updated)
-----

  build.gradle 459c79d1842bb6ee73e6a4ce8fd17b31113c3e79 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 

Diff: https://reviews.apache.org/r/26997/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

Posted by Kevin Sweeney <ke...@apache.org>.

> On Oct. 21, 2014, 6:40 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java, line 150
> > <https://reviews.apache.org/r/26997/diff/1/?file=728016#file728016line150>
> >
> >     Consider sticking to the standard here of using guava's ToStringHelper instead:
> >     
> >     http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/base/MoreObjects.html#toStringHelper(java.lang.Object)

+1 to that


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57723
-----------------------------------------------------------


On Oct. 21, 2014, 2:24 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26997/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 2:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-824
>     https://issues.apache.org/jira/browse/AURORA-824
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding quota check into scheduleCronJob.
> 
> Also, added missing tests for cron-related RPCs.
> 
> 
> Diffs
> -----
> 
>   build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 
> 
> Diff: https://reviews.apache.org/r/26997/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57723
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java
<https://reviews.apache.org/r/26997/#comment98555>

    Consider sticking to the standard here of using guava's ToStringHelper instead:
    
    http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/base/MoreObjects.html#toStringHelper(java.lang.Object)


- Bill Farner


On Oct. 21, 2014, 9:24 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26997/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 9:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-824
>     https://issues.apache.org/jira/browse/AURORA-824
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding quota check into scheduleCronJob.
> 
> Also, added missing tests for cron-related RPCs.
> 
> 
> Diffs
> -----
> 
>   build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 
> 
> Diff: https://reviews.apache.org/r/26997/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57688
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Oct. 21, 2014, 9:24 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26997/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 9:24 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-824
>     https://issues.apache.org/jira/browse/AURORA-824
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding quota check into scheduleCronJob.
> 
> Also, added missing tests for cron-related RPCs.
> 
> 
> Diffs
> -----
> 
>   build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f36a88fda3539553800bd727c3d2a77a54f1e71c 
> 
> Diff: https://reviews.apache.org/r/26997/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>