[GitHub] [kvrocks] git-hulk commented on a diff in pull request #1576: Enable dynamin compression

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1576:
URL: https://github.com/apache/kvrocks/pull/1576#discussion_r1259098944


##########
src/storage/storage.cc:
##########
@@ -180,6 +180,29 @@ rocksdb::Options Storage::InitRocksDBOptions() {
 }
 
 Status Storage::SetOptionForAllColumnFamilies(const std::string &key, const std::string &value) {
+  if ("compression" == key) {

Review Comment:
   I think we can take this into a single function like `SetCompressionOption` since it's a special setting option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org