You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2017/10/15 16:05:13 UTC

karaf git commit: [KARAF-5373] Improve the fix

Repository: karaf
Updated Branches:
  refs/heads/master fc7af0b0c -> 0c4a81921


[KARAF-5373] Improve the fix


Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/0c4a8192
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/0c4a8192
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/0c4a8192

Branch: refs/heads/master
Commit: 0c4a819217cb35c59cc4c2d41369ca3f27e7cd12
Parents: fc7af0b
Author: Jean-Baptiste Onofré <jb...@apache.org>
Authored: Sun Oct 15 18:04:48 2017 +0200
Committer: Jean-Baptiste Onofré <jb...@apache.org>
Committed: Sun Oct 15 18:04:48 2017 +0200

----------------------------------------------------------------------
 .../apache/karaf/tooling/features/GenerateDescriptorMojo.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf/blob/0c4a8192/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
----------------------------------------------------------------------
diff --git a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
index 896c128..0b27da4 100644
--- a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
+++ b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
@@ -318,7 +318,7 @@ public class GenerateDescriptorMojo extends MojoSupport {
         try {
             if (enableGeneration == null) {
                 String packaging = this.project.getPackaging();
-                enableGeneration = !"feature".equals(packaging);
+                enableGeneration = "feature".equals(packaging);
             }
 
             if (!enableGeneration) {
@@ -329,8 +329,8 @@ public class GenerateDescriptorMojo extends MojoSupport {
                     }
                     filter(inputFile, outputFile);
                     projectHelper.attachArtifact(project, attachmentArtifactType, attachmentArtifactClassifier, outputFile);
-                    return;
                 }
+                return;
             }
 
             this.dependencyHelper = DependencyHelperFactory.createDependencyHelper(this.container, this.project, this.mavenSession, getLog());