You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/20 00:31:45 UTC

[GitHub] [spark] yangwwei commented on pull request #34319: [SPARK-37049] executorIdleTimeout is not working for pending pods on K8s

yangwwei commented on pull request #34319:
URL: https://github.com/apache/spark/pull/34319#issuecomment-947208231


   > > The PR includes the UT changes, that has the testing coverage for this issue.
   > 
   > So existing tests was not really testing this problem at all as it always filled out this field (this does not changed by this PR).
   > 
   > Here we need some proof from manual testing. So can you please attach/quote parts from logs into the PR description where we can see the problem?
   
   hi @attilapiros I've updated the description, which includes the steps I was using to reproduce this locally, as well as some more logs. Please take a look. The fix is pretty straightforward, after having the fix, the executorIdleTimeout starts to work for the pending pods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org