[jira] [Reopened] (BEAM-11982) Java Spanner - Implement IO Request Count metrics

["Niel Markwick (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niel Markwick reopened BEAM-11982:
----------------------------------

Reopening as this breaks backward compatibility. 

[BatchSpannerRead.java:175|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java#L175] calls toString() on the valueproviders, which can throw a null pointer exception if they are not set (it should call `get()`) 

The projectId value is optional as it can be inferred from the environment, and if it is not set, this line will throw a runtime NPE. 

Please fix, and also update createServiceCallMetric to handle the possibility of a NULL projectID

> Java Spanner - Implement IO Request Count metrics
> -------------------------------------------------
>
>                 Key: BEAM-11982
>                 URL: https://issues.apache.org/jira/browse/BEAM-11982
>             Project: Beam
>          Issue Type: Test
>          Components: io-java-gcp
>            Reporter: Alex Amato
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>             Fix For: Missing
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's needed to instrument this IO with Request Count metrics is found in this handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)