You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/27 14:57:39 UTC
[GitHub] [skywalking] ascrutae commented on a change in pull request #6783: fix a bug that spring-mvc set an error endpoint name
ascrutae commented on a change in pull request #6783:
URL: https://github.com/apache/skywalking/pull/6783#discussion_r621292480
##########
File path: test/plugin/scenarios/spring-3.0.x-scenario/config/expectedData.yaml
##########
@@ -14,52 +14,130 @@
# See the License for the specific language governing permissions and
# limitations under the License.
segmentItems:
-- serviceName: spring-3.0.x-scenario
- segmentSize: ge 2
- segments:
- - segmentId: not null
- spans:
- - operationName: /healthCheck
- operationId: 0
- parentSpanId: -1
- spanId: 0
- spanLayer: Http
- startTime: nq 0
- endTime: nq 0
- componentId: 14
- isError: false
- spanType: Entry
- peer: ''
- tags:
- - {key: url, value: 'http://localhost:8080/spring-3.0.x-scenario/healthCheck'}
- - {key: http.method, value: HEAD}
- skipAnalysis: 'false'
- - segmentId: not null
- spans:
- - {operationName: test.apache.skywalking.apm.testcase.spring3.component.TestComponentBean.componentMethod,
- operationId: 0, parentSpanId: 1, spanId: 2, spanLayer: Unknown, startTime: nq
- 0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, peer: '',
- skipAnalysis: 'false'}
- - {operationName: test.apache.skywalking.apm.testcase.spring3.dao.TestRepositoryBean.doSomeStuff,
- operationId: 0, parentSpanId: 1, spanId: 3, spanLayer: Unknown, startTime: nq
- 0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, peer: '',
- skipAnalysis: 'false'}
- - {operationName: test.apache.skywalking.apm.testcase.spring3.service.TestServiceBean.doSomeBusiness,
- operationId: 0, parentSpanId: 0, spanId: 1, spanLayer: Unknown, startTime: nq
- 0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, peer: '',
- skipAnalysis: 'false'}
- - operationName: /case/spring3
- operationId: 0
- parentSpanId: -1
- spanId: 0
- spanLayer: Http
- startTime: nq 0
- endTime: nq 0
- componentId: 14
- isError: false
- spanType: Entry
- peer: ''
- tags:
- - {key: url, value: 'http://localhost:8080/spring-3.0.x-scenario/case/spring3'}
- - {key: http.method, value: GET}
- skipAnalysis: 'false'
+ - serviceName: spring-3.0.x-scenario
+ segmentSize: ge 4
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /healthCheck
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 14
+ isError: false
+ spanType: Entry
+ peer: ''
+ skipAnalysis: false
+ tags:
+ - {key: url, value: 'http://localhost:8080/spring-3.0.x-scenario/healthCheck'}
+ - {key: http.method, value: HEAD}
+ - segmentId: not null
+ spans:
+ - operationName: /impl/requestmapping
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 14
+ isError: false
+ spanType: Entry
+ peer: ''
+ skipAnalysis: false
+ tags:
+ - {key: url, value: 'http://localhost:8080/spring-3.0.x-scenario//impl/requestmapping'}
Review comment:
The URL which has more '/' char looks strange, I think that `http://localhost:8080/spring-3.0.x-scenario/impl/requestmapping` prefer looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org