[jira] [Commented] (YARN-3106) The message in IllegalArgumentException gave wrong information in NMTokenSecretManagerInRM.java and RMContainerTokenSecretManager.java

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295732#comment-14295732 ] 

Hadoop QA commented on YARN-3106:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12695048/YARN-3106.000.patch
  against trunk revision 9850e15.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6437//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6437//console

This message is automatically generated.

> The message in IllegalArgumentException gave wrong information in NMTokenSecretManagerInRM.java and RMContainerTokenSecretManager.java
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3106
>                 URL: https://issues.apache.org/jira/browse/YARN-3106
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-3106.000.patch
>
>
> The message in IllegalArgumentException gave wrong information in NMTokenSecretManagerInRM.java and RMContainerTokenSecretManager.java.
> We saw this error message:
> {code}
> Error starting ResourceManager
> java.lang.IllegalArgumentException: yarn.resourcemanager.nm-tokens.master-key-rolling-interval-secs should be more than 2 X yarn.nm.liveness-monitor.expiry-interval-ms
> {code}
> After I checked the source code, I find this error message misleading.
> The following is code from NMTokenSecretManagerInRM.java
> {code}
>     rollingInterval = this.conf.getLong(        YarnConfiguration.RM_NMTOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,    YarnConfiguration.DEFAULT_RM_NMTOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS)  * 1000;
>     this.activationDelay =        (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
>             YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
>     LOG.info("NMTokenKeyRollingInterval: " + this.rollingInterval
>         + "ms and NMTokenKeyActivationDelay: " + this.activationDelay
>         + "ms");
>     if (rollingInterval <= activationDelay * 2) {
>       throw new IllegalArgumentException(         YarnConfiguration.RM_NMTOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS              + " should be more than 2 X "
>               + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
>     }
> {code}
> It should be 3 X not 2 X.
> Same error also happened in RMContainerTokenSecretManager.java.
> {code}
>    this.rollingInterval = conf.getLong(   YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,       YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS) * 1000;
>     this.activationDelay =
>         (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
>             YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
>     LOG.info("ContainerTokenKeyRollingInterval: " + this.rollingInterval
>         + "ms and ContainerTokenKeyActivationDelay: " + this.activationDelay
>         + "ms");
>     if (rollingInterval <= activationDelay * 2) {
>       throw new IllegalArgumentException(      YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS              + " should be more than 2 X "            +YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)