[GitHub] peng-yongsheng commented on a change in pull request #1252: Update release doc and related script

[GitBox <gi...@apache.org>]

peng-yongsheng commented on a change in pull request #1252: Update release doc and related script
URL: https://github.com/apache/incubator-skywalking/pull/1252#discussion_r189954005
 
 

 ##########
 File path: tools/releasing/create_source_release.sh
 ##########
 @@ -20,11 +20,13 @@
 # This script relies on few environment variables to determine source code package
 # behavior, those variables are:
 #   RELEASE_VERSION -- The version of this source package.
+#   RELEASE_ROUND -- The round of this version release.
 # For example: RELEASE_VERSION=5.0.0-alpha
+#              RELEASE_ROUND=1
 
 
 RELEASE_VERSION=${RELEASE_VERSION}
-TAG_NAME="v"${RELEASE_VERSION}
+TAG_NAME=${RELEASE_VERSION}(RC${RELEASE_ROUND})
 
 Review comment:
   @wu-sheng I changed it, do you agree?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services