You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "minal-kyada (via GitHub)" <gi...@apache.org> on 2026/07/10 21:27:29 UTC
[PR] System peers tables may be incorrectly repaired during a rolling upgrade. [cassandra]
minal-kyada opened a new pull request, #4924:
URL: https://github.com/apache/cassandra/pull/4924
During a rolling upgrade from 4.0.4 to 4.0.5, the system peers tables are expected to be temporarily divergent from ClusterMetadata. Nodes still on 4.0.4 have not yet registered with TCM, so their peer table entries are not fully reflected in ClusterMetadata.directory.
SystemPeersValidator.validateAndRepair() does not account for this window, making it possible for the peers tables to end up in an incorrect state where valid peer entries have been removed or overwritten.
patch by @minal-kyada ; reviewed by @beobal and @maedhroz for CASSANDRA-21503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] System peers tables may be incorrectly repaired during a rolling upgrade. [cassandra]
Posted by "minal-kyada (via GitHub)" <gi...@apache.org>.
minal-kyada closed pull request #4924: System peers tables may be incorrectly repaired during a rolling upgrade.
URL: https://github.com/apache/cassandra/pull/4924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] System peers tables may be incorrectly repaired during a rolling upgrade. [cassandra]
Posted by "minal-kyada (via GitHub)" <gi...@apache.org>.
minal-kyada commented on PR #4924:
URL: https://github.com/apache/cassandra/pull/4924#issuecomment-4962605733
This was already fixed in SystemPeersValidator by https://github.com/apache/cassandra/commit/896d1d64157e2d4064b5931cdb907267b629846e
Hence, closing the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] System peers tables may be incorrectly repaired during a rolling upgrade. [cassandra]
Posted by "minal-kyada (via GitHub)" <gi...@apache.org>.
minal-kyada commented on code in PR #4924:
URL: https://github.com/apache/cassandra/pull/4924#discussion_r3574086548
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -858,7 +859,7 @@ public void runMayThrow() throws InterruptedException, ExecutionException, IOExc
RegistrationStatus.instance.onRegistration();
Startup.maybeExecuteStartupTransformation(self);
- if (CassandraRelevantProperties.SYNC_SYSTEM_PEERS_TABLES_AT_STARTUP.getBoolean())
+ if (CassandraRelevantProperties.SYNC_SYSTEM_PEERS_TABLES_AT_STARTUP.getBoolean() && ClusterMetadata.current().epoch.isAfter(Epoch.FIRST))
Review Comment:
Sure! will close this PR in that case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] System peers tables may be incorrectly repaired during a rolling upgrade. [cassandra]
Posted by "beobal (via GitHub)" <gi...@apache.org>.
beobal commented on code in PR #4924:
URL: https://github.com/apache/cassandra/pull/4924#discussion_r3571537645
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -858,7 +859,7 @@ public void runMayThrow() throws InterruptedException, ExecutionException, IOExc
RegistrationStatus.instance.onRegistration();
Startup.maybeExecuteStartupTransformation(self);
- if (CassandraRelevantProperties.SYNC_SYSTEM_PEERS_TABLES_AT_STARTUP.getBoolean())
+ if (CassandraRelevantProperties.SYNC_SYSTEM_PEERS_TABLES_AT_STARTUP.getBoolean() && ClusterMetadata.current().epoch.isAfter(Epoch.FIRST))
Review Comment:
This was already fixed in `SystemPeersValidator` by 896d1d6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org