You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/16 11:36:06 UTC

[GitHub] [flink] twalthr opened a new pull request, #19734: [FLINK-27492][table] Introduce flink-table-api-scala-uber for convenience

twalthr opened a new pull request, #19734:
URL: https://github.com/apache/flink/pull/19734

   ## What is the purpose of the change
   
   Introduces a `flink-table-api-scala-uber` similar to the `flink-table-api-java-uber` we already have in the distribution. This also matches to CEP and Gelly which also offer a Scala JAR in the `/opt` folder to be moved to `/lib` if required.
   
   ## Brief change log
   
   Add `flink-table-api-scala-uber` in `/opt`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19734: [FLINK-27492][table] Introduce flink-table-api-scala-uber for convenience

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19734:
URL: https://github.com/apache/flink/pull/19734#issuecomment-1131505087

   > Would we then also include gelly and cep? Both are currently also available in the /opt folder.
   
   I thought so, yes. If you use the gelly/cep scala APIs you need the flink-dist-scala jar in lib/ anyway.
   
   > flink-table-api-scala does not rely on flink-scala.
   
   Is this also true in practice considering the Kryo extensions in flink-scala? (Which also end up in savepoints iirc)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19734: [FLINK-27492][table] Introduce flink-table-api-scala-uber for convenience

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19734:
URL: https://github.com/apache/flink/pull/19734#issuecomment-1174747313

   @twalthr Do you have time to finalize this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #19734: [FLINK-27492][table] Introduce flink-table-api-scala-uber for convenience

Posted by GitBox <gi...@apache.org>.
twalthr commented on PR #19734:
URL: https://github.com/apache/flink/pull/19734#issuecomment-1130128858

   `flink-table-api-scala` does not rely on `flink-scala`. In theory, we don't need to pull the entire DataStream API for Table API users. But since we bundle `flink-table-api-scala-bridge` in there as well. Yes, we can offer an entire `flink-dist-scala`. Would we then also include gelly and cep? Both are currently also available in the `/opt` folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19734: [FLINK-27492][table] Introduce flink-table-api-scala-uber for convenience

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19734:
URL: https://github.com/apache/flink/pull/19734#issuecomment-1127563238

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bcb50f147e226b56718d28e73c3e5c1391db186f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bcb50f147e226b56718d28e73c3e5c1391db186f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bcb50f147e226b56718d28e73c3e5c1391db186f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org