[GitHub] [geode-native] pivotal-jbarrett commented on pull request #608: GEODE-8207: Enfore No Unknown Pragmas as Error

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on pull request #608:
URL: https://github.com/apache/geode-native/pull/608#issuecomment-640794162


   > I switched to definitions in config.h
   
   I forgot that those were unprefixed definitions in there. We should fix that some day so they don't collide with others.
   
   > but also spent a little time trying to figure out the correct way in cmake to detect those pragmas. I didn't succeed in the latter, kept ending up in docs for checking compiler flags. The closest I hit to was `get_target_property` but couldn't figure out what target or property I'd really be looking for. If you have thoughts on detection, I can take another try at using cmake to determine if those pragmas exist (as long as folks don't mind waiting a week in between my attempts based on my current schedule)
   
   I believe you want to use `check_cxx_source_compiles`.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org