You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by anusha bilgi <an...@citrix.com> on 2014/11/25 11:24:08 UTC
Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: cloudstack-6282
https://issues.apache.org/jira/browse/cloudstack-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 Added automated ACL tests
Diffs
-----
test/integration/component/test_escalations_networks.py fb2196c
Diff: https://reviews.apache.org/r/28437/diff/
Testing
-------
Tests the changed files and attached are the results for the same
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
Thanks,
anusha bilgi
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/#review76351
-----------------------------------------------------------
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment123913>
Please change import * to specific imports.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment123914>
Please remove the white-spaces.
- Gaurav Aradhye
On March 13, 2015, 4:43 p.m., anusha bilgi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28437/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 4:43 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 Added automated ACL tests
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py fb2196c
>
> Diff: https://reviews.apache.org/r/28437/diff/
>
>
> Testing
> -------
>
> Tests the changed files and attached are the results for the same
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
>
>
> Thanks,
>
> anusha bilgi
>
>
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/#review78976
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On March 16, 2015, 10:25 a.m., anusha bilgi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28437/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 10:25 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 Added automated ACL tests
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py fb2196c
>
> Diff: https://reviews.apache.org/r/28437/diff/
>
>
> Testing
> -------
>
> Tests the changed files and attached are the results for the same
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
>
>
> Thanks,
>
> anusha bilgi
>
>
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by anusha bilgi <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/
-----------------------------------------------------------
(Updated March 16, 2015, 10:25 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Added specific imports to test_escalations_networks.py
Bugs: cloudstack-6282
https://issues.apache.org/jira/browse/cloudstack-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 Added automated ACL tests
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py fb2196c
Diff: https://reviews.apache.org/r/28437/diff/
Testing
-------
Tests the changed files and attached are the results for the same
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
Thanks,
anusha bilgi
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by anusha bilgi <an...@citrix.com>.
> On March 16, 2015, 8:46 a.m., Gaurav Aradhye wrote:
> > test/integration/component/test_escalations_networks.py, line 20
> > <https://reviews.apache.org/r/28437/diff/3/?file=895460#file895460line20>
> >
> > Please remvoe all import *
Hi,
I have made the changes and uploaded the same.
Could you review this.
Thanks,
Anusha
- anusha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/#review76539
-----------------------------------------------------------
On March 16, 2015, 10:25 a.m., anusha bilgi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28437/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 10:25 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 Added automated ACL tests
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py fb2196c
>
> Diff: https://reviews.apache.org/r/28437/diff/
>
>
> Testing
> -------
>
> Tests the changed files and attached are the results for the same
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
>
>
> Thanks,
>
> anusha bilgi
>
>
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/#review76539
-----------------------------------------------------------
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment124109>
Please remvoe all import *
- Gaurav Aradhye
On March 16, 2015, 2:08 p.m., anusha bilgi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28437/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 2:08 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 Added automated ACL tests
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py fb2196c
>
> Diff: https://reviews.apache.org/r/28437/diff/
>
>
> Testing
> -------
>
> Tests the changed files and attached are the results for the same
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
>
>
> Thanks,
>
> anusha bilgi
>
>
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by anusha bilgi <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/
-----------------------------------------------------------
(Updated March 16, 2015, 8:38 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified tests to incorporate review comments. Review the same.
Bugs: cloudstack-6282
https://issues.apache.org/jira/browse/cloudstack-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 Added automated ACL tests
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py fb2196c
Diff: https://reviews.apache.org/r/28437/diff/
Testing
-------
Tests the changed files and attached are the results for the same
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
Thanks,
anusha bilgi
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by anusha bilgi <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/
-----------------------------------------------------------
(Updated March 13, 2015, 11:13 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified tests as per review comments and uploaded latest patch. review the same. Also executed all tests after changes and all tests are workign fine.
Bugs: cloudstack-6282
https://issues.apache.org/jira/browse/cloudstack-6282
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6282 Added automated ACL tests
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py fb2196c
Diff: https://reviews.apache.org/r/28437/diff/
Testing
-------
Tests the changed files and attached are the results for the same
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
Thanks,
anusha bilgi
Re: Review Request 28437: CLOUDSTACK-6282 Added automated ACL tests
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28437/#review62993
-----------------------------------------------------------
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105166>
We have simple assert available through self.assert, can we use that, to keep uniform notation across all other places?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105164>
Description does not seem to represent test case name
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105163>
Is aclgroup None a failure or not None a failure?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105165>
why not simple len(aclList) instead of aclList.__len__()?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105162>
There are no steps for this test case
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105157>
This is not clear, is it that we are expecting it to be None and if not None fail the test case?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105160>
Please provide a valid name instead of network_created to some meaningful.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105161>
This network creation is not available in steps for the test
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105158>
try adding the element vpc right after creation. If test case fails for some reason between vpc creation and network creation step, then say vpc created still remain as it is and will effect other steps.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105159>
Why two asserts for same element "network_created"
- Santhosh Edukulla
On Nov. 25, 2014, 10:24 a.m., anusha bilgi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28437/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 10:24 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6282 Added automated ACL tests
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py fb2196c
>
> Diff: https://reviews.apache.org/r/28437/diff/
>
>
> Testing
> -------
>
> Tests the changed files and attached are the results for the same
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/11/25/61351189-70e9-4fa6-8bcf-035d28fa61e6__results.txt
>
>
> Thanks,
>
> anusha bilgi
>
>