You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/09/12 07:43:20 UTC

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #1070: IGNITE-17621 Fixed registration already completed future in InFlightF…

sk0x50 commented on code in PR #1070:
URL: https://github.com/apache/ignite-3/pull/1070#discussion_r968081161


##########
modules/core/src/test/java/org/apache/ignite/internal/future/InFlightFuturesTest.java:
##########
@@ -40,6 +40,16 @@ void addsFutureToInFlightSetOnRegistration() {
         assertThat(currentFutures(inFlightFutures), is(singleton(incompleteFuture)));
     }
 
+
+    @Test
+    void addsAlreadyCompletedFutureToInFlightSet() {

Review Comment:
   Yes, this makes sense to me. Will change the name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org