You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/19 07:56:07 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #220: e2e test tests
yangwwei opened a new pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (71ca4d7) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `1.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 59.73% +1.95%
==========================================
Files 32 35 +3
Lines 2859 3137 +278
==========================================
+ Hits 1652 1874 +222
- Misses 1138 1181 +43
- Partials 69 82 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.56% <ø> (+0.45%)` | :arrow_up: |
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <0.00%> (-2.31%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <0.00%> (ø)` | |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `81.53% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.94% <0.00%> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...0e87d41](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (3979774) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 57.79% +0.01%
==========================================
Files 32 32
Lines 2859 2860 +1
==========================================
+ Hits 1652 1653 +1
Misses 1138 1138
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.25% <100.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...2338bd9](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (71ca4d7) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `1.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 59.73% +1.95%
==========================================
Files 32 35 +3
Lines 2859 3137 +278
==========================================
+ Hits 1652 1874 +222
- Misses 1138 1181 +43
- Partials 69 82 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.56% <ø> (+0.45%)` | :arrow_up: |
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <0.00%> (-2.31%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <0.00%> (ø)` | |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.94% <0.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `81.53% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...71ca4d7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (3979774) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 57.79% +0.01%
==========================================
Files 32 32
Lines 2859 2860 +1
==========================================
+ Hits 1652 1653 +1
Misses 1138 1138
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.25% <100.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...71ca4d7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei closed pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
yangwwei closed pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (3979774) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 57.79% +0.01%
==========================================
Files 32 32
Lines 2859 2860 +1
==========================================
+ Hits 1652 1653 +1
Misses 1138 1138
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.25% <100.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...3979774](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (0e87d41) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `1.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 59.73% +1.95%
==========================================
Files 32 35 +3
Lines 2859 3137 +278
==========================================
+ Hits 1652 1874 +222
- Misses 1138 1181 +43
- Partials 69 82 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.56% <ø> (+0.45%)` | :arrow_up: |
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <0.00%> (-2.31%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <0.00%> (ø)` | |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.94% <0.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `81.53% <0.00%> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...89fd694](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (0e87d41) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `1.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 59.73% +1.95%
==========================================
Files 32 35 +3
Lines 2859 3137 +278
==========================================
+ Hits 1652 1874 +222
- Misses 1138 1181 +43
- Partials 69 82 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.56% <ø> (+0.45%)` | :arrow_up: |
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <0.00%> (-2.31%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <0.00%> (ø)` | |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.94% <0.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `81.53% <0.00%> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...89fd694](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (0e87d41) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `1.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 57.78% 59.73% +1.95%
==========================================
Files 32 35 +3
Lines 2859 3137 +278
==========================================
+ Hits 1652 1874 +222
- Misses 1138 1181 +43
- Partials 69 82 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.56% <ø> (+0.45%)` | :arrow_up: |
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <0.00%> (-2.31%)` | :arrow_down: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <0.00%> (ø)` | |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `81.53% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.94% <0.00%> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <0.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...0e87d41](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=h1) Report
> Merging [#220](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=desc) (3979774) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **decrease** coverage by `0.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 57.78% 57.44% -0.34%
==========================================
Files 32 32
Lines 2859 2860 +1
==========================================
- Hits 1652 1643 -9
- Misses 1138 1147 +9
- Partials 69 70 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.25% <100.00%> (+0.15%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.97% <0.00%> (-4.66%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=footer). Last update [eb888df...3979774](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/220?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220#issuecomment-762711904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei closed pull request #220: e2e test tests
Posted by GitBox <gi...@apache.org>.
yangwwei closed pull request #220:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org