[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4341: Rewrite get to_extensions

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4341: Rewrite get to_extensions
URL: https://github.com/apache/trafficcontrol/pull/4341#discussion_r373211940
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/plugin/README.md
 ##########
 @@ -23,7 +23,7 @@ To add a plugin, create a new `.go` file in the `traffic_ops_golang/plugin` dire
 
 The filename, sans `.go`, is the name of your plugin, and will be the key used for configuration in the remap file. For example, if your file is `f49e54fc-fd17-4e1c-92c6-67028fde8504-hello-world.go`, the name of your plugin is `f49e54fc-fd17-4e1c-92c6-67028fde8504-hello-world`.
 
-Plugins are registered via calls to `AddPlugin` inside an `init` function in the plugin's file. The `AddPlugin` function takes a priority, and a set of hook functions. The priority is the order in which plugins are called, starting from 0. Note the priority of plugins included with Traffic Control use a base priority of 10000, unless priority order matters for them.
+Plugins are registered via calls to `AddPlugin` inside an `init` function in the plugin's file. The `AddPlugin` function takes a priority, a set of hook functions, a description and a version of the plugin. The priority is the order in which plugins are called, starting from 0. Note the priority of plugins included with Traffic Control use a base priority of 10000, unless priority order matters for them.
 
 Review comment:
   > tfw no oxford comma 😧 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services